Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TD-191 prevent user adding themself as a supervised member of staff #1457

Conversation

OluwatobiAwe
Copy link
Collaborator

JIRA link

TD-191

Description

Prevent supervisor adding self to staff list

Screenshots

Page1
Page2


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my own MR to ensure everything is as expected and it looks right in the browser

@kevwhitt-hee kevwhitt-hee changed the title supervisor email check TD-191 supervisor email check Nov 8, 2022
@kevwhitt-hee kevwhitt-hee changed the title TD-191 supervisor email check TD-191 prevent user adding themself as a supervised member of staff Nov 8, 2022
@kevwhitt-hee kevwhitt-hee merged commit 6b73801 into master Nov 10, 2022
@kevwhitt-hee kevwhitt-hee deleted the Develop/Fixes/TD-191-prevent-supervisor-adding-self-to-staff-list branch March 22, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants