Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TD-202 allow supervisor to see self assessments that their staff are already on #1478

Conversation

OluwatobiAwe
Copy link
Collaborator

@OluwatobiAwe OluwatobiAwe commented Nov 22, 2022

JIRA link

TD-202

Description

Allow supervisor to see self-assessments that their staff are already on and assign themselves as supervisor.

  • The assessment count on staff list page now shows the sum of assessment assigned to the supervisor and assessment not asigned to any supervisor
  • The list of assessment of a staffer shows assessment assigned to the logged in supervisor as well as assessment not assigned to any supervisor

Screenshots

202-1
202-2


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but we need to allow the supervisor to choose their role if there is more than one matching role in SupervisorSelfAssessmentRoles

We should base the view that allows them to choose their role on: DigitalLearningSolutions.Web\Views\Supervisor\EnrolDelegateSupervisorRole.cshtml
(used when supervisor enrols a delegate on a new self assessment)

@kevwhitt-hee kevwhitt-hee changed the title Develop/fixes/td 202 allow supervisor to see self assessments that their staff are already on TD-202 allow supervisor to see self assessments that their staff are already on Dec 12, 2022
Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to implement a confirmation screen for this flow similar to the summary screen in the Supervisor Enrol flow.

All of this will need checking and tweaking for the UAR/Passporting code changes. It is probably worth doing that now and creating a new PR to the UAR-TEST branch.

@kevwhitt-hee kevwhitt-hee self-requested a review January 4, 2023 15:20
@kevwhitt-hee kevwhitt-hee merged commit 72e8bab into master Jan 4, 2023
@kevwhitt-hee kevwhitt-hee deleted the Develop/Fixes/TD-202-allow-supervisor-to-see-self-assessments-that-their-staff-are-already-on branch January 4, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants