Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TD-4774 Correcting Condition For SignOff Button #2876

Merged
merged 1 commit into from
Oct 9, 2024
Merged

TD-4774 Correcting Condition For SignOff Button #2876

merged 1 commit into from
Oct 9, 2024

Conversation

rshrirohit
Copy link
Collaborator

@rshrirohit rshrirohit commented Oct 9, 2024 •
edited
Loading

JIRA link

TD-4774

Description

Correcting Condition For SignOff Button

Screenshots

Attach screenshots on mobile, tablet and desktop.

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@rshrirohit rshrirohit marked this pull request as ready for review October 9, 2024 07:19
Auldrin-Possa
Auldrin-Possa reviewed Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@Auldrin-Possa Auldrin-Possa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rshrirohit rshrirohit merged commit 30e8a74 into Release-2024.38 Oct 9, 2024
2 checks passed
@rshrirohit rshrirohit deleted the Develop/Fixes/TD-4774-CorrectingConditionOfSignOffButton branch October 9, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Auldrin-Possa Auldrin-Possa Auldrin-Possa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rshrirohit @Auldrin-Possa