HEEDLS-465 - Implemented basic support page #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJacksonDS
approved these changes
Jun 17, 2021
DigitalLearningSolutions.Web.AutomatedUiTests/AccessibilityTests/BasicAccessibilityTests.cs
Outdated
Show resolved
Hide resolved
stellake
reviewed
Jun 21, 2021
DigitalLearningSolutions.Web/Views/LearningSolutions/Support.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/LearningSolutions/Shared/_SupportSideNavMenu.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web.Tests/Controllers/LearningSolutions/SupportControllerTests.cs
Outdated
Show resolved
Hide resolved
stellake
reviewed
Jun 25, 2021
DigitalLearningSolutions.Web/Controllers/LearningSolutions/SupportController.cs
Outdated
Show resolved
Hide resolved
stellake
reviewed
Jun 25, 2021
DigitalLearningSolutions.Web/Controllers/LearningSolutions/SupportController.cs
Outdated
Show resolved
Hide resolved
stellake
reviewed
Jun 25, 2021
| ApplicationType.Frameworks == application) | ||
| { | ||
| return View( | ||
| "/Views/LearningSolutions/Support.cshtml", |
There was a problem hiding this comment.
Could we fix this like we've done in TrackingSystem pages? We might actually not even want the controller to be in LearningSolutions folder given that we won't be including that in the url (could argue either way tbh, so feel free to do whatever is the most convenient 👍 )
stellake
reviewed
Jun 25, 2021
DigitalLearningSolutions.Web/ViewModels/LearningSolutions/SupportViewModel.cs
Outdated
Show resolved
Hide resolved
stellake
reviewed
Jun 25, 2021
stellake
reviewed
Jun 28, 2021
Comment on lines
89
to
92
| return user.GetCustomClaimAsBool(CustomClaimTypes.IsFrameworkDeveloper) == true | | ||
| user.GetCustomClaimAsBool(CustomClaimTypes.IsFrameworkContributor) == true | | ||
| user.GetCustomClaimAsBool(CustomClaimTypes.IsWorkforceManager) == true | | ||
| user.GetCustomClaimAsBool(CustomClaimTypes.IsWorkforceContributor) == true; |
stellake
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran all unit tests.
Checked in Chrome, IE11, Edge, Firefox.
Tested with screenreader, mobile view/zoom.
Screen shots:
Desktop (tracking system):
Desktop (frameworks, see nav bar difference):
Mobile views
