HEEDLS-524 Refactor prompt management pages for consistent spacing #440
Conversation
|
It feels like there's quite a big gap below the headings on the Add and Remove pages, probably because of the margins on text elements. I'm guessing it's the same distance between the headers and next elements on all pages. I think I'd be inclined to make the space a bit smaller, but happy for @stellake to overrule me! |
...gSystem/CentreConfiguration/RegistrationPrompts/AddRegistrationPromptConfigureAnswers.cshtml
Show resolved
Hide resolved
...rningSolutions.Web/Views/TrackingSystem/CentreConfiguration/RegistrationPrompts/Index.cshtml
Outdated
Show resolved
Hide resolved
|
The spacing after all the titles should be 48px for desktop, 40 for mobile. This comes from the nhsuk-heading-xl style and is consistent across all the files. |
...rningSolutions.Web/Views/TrackingSystem/CentreConfiguration/RegistrationPrompts/Index.cshtml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I think the spacing looks ok with the expanders and agree that if there is no expander directly after the heading, it does look a bit spacious. However, if this gap comes from the nhs-heading class as Alex mentioned, I think we should keep the default, but make sure it's consistent across pages. 👍
Just looking at the Centre ranking review and the spacing looks different there :P |
id="page-heading" reduces the margin (and nothing else as far as I can see). I've been removing it as I've fixed these. I guess I need to remove it over there too. |
Changed all the pages in the manage registration prompt area to have approximately equal spacing between the h1 elements and the page content and the bottom of the content and the back link view component.