Drop PYTHONOPTIMIZE=2 hacks and upgrade Werkzeug #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajo
force-pushed
the
master-werkzeug
branch
2 times, most recently
from
c2883e5 to
8cea411
Compare
Since Werkzeug's version is hardcoded to a lower one in every Odoo supported version and fork, the easiest patch is to install it as odoo user, which will take precedence over the version installed by automated tools. Took the chance to use `$PIP_NO_CACHE_DIR=0` as explained in pypa/pip#2897 (comment) instead of adding `--no-cache-dir` everywhere. Fix #19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Werkzeug's version is hardcoded to a lower one in every Odoo supported version and fork, the easiest patch is to install it as odoo user, which will take precedence over the version installed by automated tools.
Took the chance to use
$PIP_NO_CACHE_DIRinstead of adding--no-cache-direverywhere.Related to #132 and pypa/pip#2897 (comment), fixes #21, fixes #19.