Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for enum variant discriminant #104

Closed
katyo opened this issue Dec 9, 2020 · 5 comments · Fixed by #105
Closed

Support for enum variant discriminant #104

katyo opened this issue Dec 9, 2020 · 5 comments · Fixed by #105
Labels
enhancement

Comments

@katyo
Copy link

katyo commented Dec 9, 2020

As I see currently FromVariant derive macro has missing support for discriminant part of enum variants.
I think it will be good to support it too.
TedDriggs added a commit that referenced this issue Dec 9, 2020
@TedDriggs
Add FromVariant discriminant magic field
dec5a06 
Fixes #104
@TedDriggs TedDriggs mentioned this issue Dec 9, 2020
Merged
@TedDriggs
Copy link
Owner

I've put up a PR for it; please take a look and let me know if it solves your use-case.

@katyo
Copy link
Author

katyo commented Dec 10, 2020

LGTM.
I tested this feature in rquickjs#12.
Works complettely as expected.

TedDriggs added a commit that referenced this issue Dec 10, 2020
@TedDriggs
Add FromVariant discriminant magic field (#105)
13fc63f 
Fixes #104
@TedDriggs
Copy link
Owner

Excellent. I'll push out a new version tomorrow morning.

@katyo
Copy link
Author

katyo commented Dec 10, 2020

@TedDriggs Great thanks for super fast support!

@TedDriggs
Copy link
Owner

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add FromVariant discriminant magic field TedDriggs/darling
2 participants
@katyo @TedDriggs