Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 2018 Edition #127

Closed
3 tasks done
TedDriggs opened this issue Apr 8, 2021 · 2 comments
Closed
3 tasks done

Update to 2018 Edition #127

TedDriggs opened this issue Apr 8, 2021 · 2 comments
Labels
help wanted

Comments

@TedDriggs
Copy link
Owner

TedDriggs commented Apr 8, 2021 •
edited
Loading

Per this comment, darling can move to the 2018 edition, and code it emits will be treated according to those rules even if the calling crate is on 2015 Rust.

Staying on 2015 is going to make contribution to darling harder over time, and the migration will probably get harder over time. However, the migration is going to be hard due to lack of a test plan.

  • Migrate all code outside quote macros
  • Migrate code inside quote macros
  • Test from a crate that is still on 2015

This should probably be a minor version bump.
TedDriggs added a commit that referenced this issue Apr 20, 2021
@TedDriggs
Update to 2018
cd9fbac 
* Fix relative visibility
* Fix imports to use crate::
* Remove most unnecessary macro imports
* Fix all warnings in tests and examples

First step of #127
@TedDriggs TedDriggs mentioned this issue Apr 20, 2021
Merged
TedDriggs added a commit that referenced this issue Apr 20, 2021
@TedDriggs
Update to 2018
b01350d 
* Fix relative visibility in darling_core
* Fix imports to use crate::
* Remove most unnecessary `#[macro_use]` and `extern crate` lines
* Fix all warnings in tests and examples
* Add self:: to core/lib.rs to compile on 1.31.0

First step of #127
TedDriggs added a commit that referenced this issue Apr 20, 2021
@TedDriggs
Update to 2018
0add687 
* Fix relative visibility in darling_core
* Fix imports to use crate::
* Remove most unnecessary `#[macro_use]` and `extern crate` lines
* Fix all warnings in tests and examples
* Add self:: to core/lib.rs to compile on 1.31.0

First step of #127
@TedDriggs
Copy link
Owner Author

@kangalioo 79 files changed later, I think this is ready to go. Planning to roll one more change in and to then call it 0.13.0-beta

@kangalio
Copy link
Contributor

Wow, I wasn't aware you were already hard at work on this! Really cool, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TedDriggs @kangalio