Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using #[derive(FromDeriveInput)] without #[darling(attributes)] should compile #183

Closed
TedDriggs opened this issue Apr 26, 2022 · 0 comments · Fixed by #185
Closed

Using #[derive(FromDeriveInput)] without #[darling(attributes)] should compile #183

TedDriggs opened this issue Apr 26, 2022 · 0 comments · Fixed by #185
Assignees
@TedDriggs
Labels
bug

Comments

@TedDriggs
Copy link
Owner

Instead, it fails because of #177
@TedDriggs TedDriggs added the bug label Apr 26, 2022
@TedDriggs TedDriggs self-assigned this Apr 26, 2022
TedDriggs added a commit that referenced this issue Apr 26, 2022
@TedDriggs
Always declare locals as mutable in derived impls
37c53b8 
Values for fields are kept in local variables prior to construction in
the `From*` derivations. Before #177, these local variables would be
immutable, since nothing would ever modify them. However, now the
generated code will mutate the local variable to insert the result of
a `from_none` call to the child. Therefore, for simplicity the variables
are always emitted as mutable.

Fixes #183
@TedDriggs TedDriggs mentioned this issue Apr 28, 2022
Merged
TedDriggs added a commit that referenced this issue Apr 28, 2022
@TedDriggs
Always declare locals as mutable in derived impls
71ecae3 
Values for fields are kept in local variables prior to construction in
the `From*` derivations. Before #177, these local variables would be
immutable, since nothing would ever modify them. However, now the
generated code will mutate the local variable to insert the result of
a `from_none` call to the child. Therefore, for simplicity the variables
are always emitted as mutable.

Fixes #183
TedDriggs added a commit that referenced this issue Apr 28, 2022
@TedDriggs
Always declare locals as mutable in derived impls
edeeb03 
Values for fields are kept in local variables prior to construction in
the `From*` derivations. Before #177, these local variables would be
immutable, since nothing would ever modify them. However, now the
generated code will mutate the local variable to insert the result of
a `from_none` call to the child. Therefore, for simplicity the variables
are always emitted as mutable.

Fixes #183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TedDriggs TedDriggs

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always declare locals as mutable in derived impls TedDriggs/darling
1 participant
@TedDriggs