Error when parsing FromMeta containing NestedMeta::Lit #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r error generation in darling
This was referenced Jul 24, 2022
|
👋🏻 |
|
Thanks for the reminder! I’m away from a computer for a few days here, but will finish reviewing when I am back. Apologies for the slow turnaround. |
TedDriggs
approved these changes
Aug 24, 2022
👍🏻 Anything I need to do for this PR for it to be mergeable? |
|
Nope - problems were all on my side. |
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Generate an error when parsing derived
FromMetaimplementations that contain aNestedMeta::Lit.Why
Literal values are unsupported in the code generated by
FromMeta. Literal values, like strings, get ignored by the parse implementation that gets generated with the FromMeta generated code. This is confusing to a user since it appears like the value is being accepted and used in some way. We should error when the user provides a literal since the derived code will do nothing with it.Fix #192