invalid reports when used with -rA, repeats 3 times with instafail

[stas00]

pytest-sugar reports strange things when used with -rA

Command used to run pytest

pytest test_example.py

Test file

def test_example():
    print(1)
    pass

Output

Test session starts (platform: linux, Python 3.8.5, pytest 6.2.2, pytest-sugar 0.9.4)
rootdir: /home/stas/hf/transformers-stas
plugins: forked-1.3.0, xdist-2.2.0, sugar-0.9.4, instafail-0.4.2
collecting ...
 test_example.py ✓                                                                                                                    100% ██████████

Results (0.02s):
       1 passed

with -rA

$ pytest -rA test_example.py
Test session starts (platform: linux, Python 3.8.5, pytest 6.2.2, pytest-sugar 0.9.4)
rootdir: /home/stas/hf/transformers-stas
plugins: forked-1.3.0, xdist-2.2.0, sugar-0.9.4, instafail-0.4.2
collecting ...
 test_example.py ✓                                                                                                                    100% ██████████
====================================================================== PASSES =======================================================================
___________________________________________________________________ test_example ____________________________________________________________________
--------------------------------------------------------------- Captured stdout call ----------------------------------------------------------------
1
___________________________________________________________________ test_example ____________________________________________________________________
--------------------------------------------------------------- Captured stdout call ----------------------------------------------------------------
1
============================================================== short test summary info ==============================================================
PASSED test_example.py::test_example
PASSED test_example.py::test_example
PASSED test_example.py::test_example

Results (0.02s):
       1 passed

2 problems:

1. stdout is dumped twice
2. PASSED report is printed trice

If combined with instafail

It now also reports the test 3 times! ✓✓✓

pytest -rA test_example.py --instafail
====================================================================== test session starts =======================================================================
platform linux -- Python 3.8.5, pytest-6.2.2, py-1.10.0, pluggy-0.13.1
rootdir: /home/stas/hf/transformers-stas
plugins: forked-1.3.0, xdist-2.2.0, sugar-0.9.4, instafail-0.4.2
collected 1 item

test_example.py ✓✓✓                                                                                                                                                            [100%]

============================================================================= PASSES =============================================================================
__________________________________________________________________________ test_example __________________________________________________________________________
---------------------------------------------------------------------- Captured stdout call ----------------------------------------------------------------------
1
__________________________________________________________________________ test_example __________________________________________________________________________
---------------------------------------------------------------------- Captured stdout call ----------------------------------------------------------------------
1
==================================================================== short test summary info =====================================================================
PASSED test_example.py::test_example
PASSED test_example.py::test_example
PASSED test_example.py::test_example
======================================================================= 3 passed in 0.06s ========================================================================

W/o -rA

pytest test_example.py --instafail
====================================================================== test session starts =======================================================================
platform linux -- Python 3.8.5, pytest-6.2.2, py-1.10.0, pluggy-0.13.1
rootdir: /home/stas/hf/transformers-stas
plugins: forked-1.3.0, xdist-2.2.0, sugar-0.9.4, instafail-0.4.2
collected 1 item

test_example.py ✓✓✓                                                                                                                                                            [100%]

======================================================================= 3 passed in 0.01s ========================================================================

Thanks.

[Teemu]

Hey 👋, pytest-sugar is actually a fork of pytest-instafail so you probably don't want both of them to be installed.

[stas00]

Thank you for the explanation of the problem, @Teemu

Should pytest-sugar print a warning or assert if both are detected - how would other users know that they must not use the 2 together?

[Teemu]

Yeah we could do that 👍

…

On Fri 11. Nov 2022 at 19.29, Stas Bekman ***@***.***> wrote: Thank you for the explanation of the problem, @Teemu <https://github.com/Teemu> Should pytest-sugar print a warning or assert if both are detected - how would other users know that they must not use the 2 together? — Reply to this email directly, view it on GitHub <#222 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAANAMTOPWMCRSJBBUODBXDWHZ7A5ANCNFSM42MAT4WA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[stas00]

Thank you, @Teemu