Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with pytest 5.4 and line number report for doctests #197

Merged
merged 3 commits into from
Jul 6, 2020

Conversation

nicoddemus
Copy link
Collaborator

@nicoddemus nicoddemus commented May 31, 2020

Hi!

While working on #194, I came across and fixed #134 as well. 👍

  • Fix line number report for doctests in pytest>=3.10
  • Fix compatibility with pytest 5.4

Fix #194
Fix #134
Fix #180
Close pytest-dev/pytest#7287

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2020

Codecov Report

Merging #197 into master will increase coverage by 0.00%.
The diff coverage is 94.11%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #197   +/-   ##
=======================================
  Coverage   87.44%   87.44%           
=======================================
  Files           2        2           
  Lines         478      486    +8     
  Branches       85       85           
=======================================
+ Hits          418      425    +7     
  Misses         35       35           
- Partials       25       26    +1     
Impacted Files Coverage Δ
test_sugar.py 99.26% <ø> (-0.01%) ⬇️
pytest_sugar.py 82.85% <94.11%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00b8100...e5eacfd. Read the comment docs.

Copy link

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ofek
Copy link

ofek commented May 31, 2020

@Teemu Hello again! Any chance this could be released soon?

@chris-erickson
Copy link

please!

@ofek
Copy link

ofek commented Jun 8, 2020

@Teemu Any update?

@tomhamiltonstubber
Copy link

Please can we get this merged?

@ofek
Copy link

ofek commented Jun 17, 2020

@Teemu Any progress?

@zackkitzmiller
Copy link

Would love to get this merged too.

@ofek
Copy link

ofek commented Jul 6, 2020

Update?

@Teemu Teemu merged commit 1e2fa15 into Teemu:master Jul 6, 2020
@Teemu
Copy link
Owner

Teemu commented Jul 6, 2020

I'm releasing a new version soon. Thanks for the PR ❤️

@nicoddemus nicoddemus deleted the issue-194 branch July 6, 2020 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants