Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for localized billing accounts #260

Merged

Conversation

vishesh92
Copy link
Contributor

If your account is billed locally by AWS, e.g. by AISPL if you are in India, then the files generated for billing have AISPL in them
239874210271-aws-billing-detailed-line-items-with-resources-and-tags-AISPL-2017-01.csv.zip

This PR adds support for these types of reports.

Copy link
Member

@NitriKx NitriKx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Billing files patterns should use "non-capturing" groups instead, and then avoid modifications on "matcher.group" calls. (http://www.rexegg.com/regex-disambiguation.html#noncap)
For instance:

Pattern.compile(".+-aws-billing-detailed-line-items-with-resources-and-tags-(?:[A-Z]+-)?(\\d\\d\\d\\d-\\d\\d).csv.zip");

@NitriKx NitriKx self-assigned this Aug 1, 2017
@NitriKx NitriKx added this to the v1.1.2 milestone Aug 1, 2017
@vishesh92 vishesh92 force-pushed the support-localized-billing-accounts branch from 25e9374 to d5d1cc3 Compare August 2, 2017 05:37
@vishesh92
Copy link
Contributor Author

@NitriKx Didn't know about that. Have updated the PR.

Copy link
Member

@NitriKx NitriKx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update

@NitriKx NitriKx merged commit d5d1cc3 into Teevity:master Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants