Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Connection Settings Edit Button behavior #744

Open
JohannesMP opened this issue Mar 31, 2014 · 1 comment
Open

Change Connection Settings Edit Button behavior #744

JohannesMP opened this issue Mar 31, 2014 · 1 comment
Milestone

Comments

@JohannesMP
Copy link

In the 0.1.6.0 test builds, when you click 'Edit' on an existing server entry in the server browser, you will see three buttons below the server info fields: New, Replace, and Cancel

Currently the behavior is as follows when you select a server and click the 'Edit' Button:

  • Cancel is always enabled (which is as it should be)
  • With no changes, New is Disabled and Replace is enabled
  • With changes to the Address or Port, New is disabled and Replace is enabled
  • With changes to the Server Name, New is enabled and Replace is disabled.

I think it would make more sense if Replace was changed to Save, and the menu exhibited the following behavior:

  • With no changes both New and Save are disabled, with the only clickable option being Cancel (which as before is always active).
  • With changes to the Address or Port, New should remain disabled and Save should be enabled
  • With changes to the Server Name Both New and Save should be enabled. This allows you to duplicate an entry as well as save over an existing one without having to go back and delete the old name entry as you currently have to when you want to change the name.
@TehGimp TehGimp added this to the v0.1.6 milestone Apr 2, 2014
TehGimp added a commit that referenced this issue Apr 2, 2014
Also tweaked connection window layout, partially addresses #744
@TehGimp
Copy link
Owner

TehGimp commented Apr 2, 2014

Partially implemented by 7020519, but still lacking the ability to change the name of a previous entry without deleting the old one.

@TehGimp TehGimp modified the milestones: v0.1.7, v0.1.6 Apr 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants