Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hippy-vue): fixed focus event support for div #387

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

xuqingkuang
Copy link
Contributor

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline.
  • Squash the repeat code commits, short patches are welcome.

Copy link
Collaborator

@zoomchan-cxj zoomchan-cxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Nov 2, 2020

Codecov Report

Merging #387 into master will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
- Coverage   58.40%   58.33%   -0.08%     
==========================================
  Files          25       25              
  Lines        1647     1649       +2     
==========================================
  Hits          962      962              
- Misses        685      687       +2     
Impacted Files Coverage Δ
packages/hippy-vue/src/elements/built-in.js 89.04% <0.00%> (-2.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8a891a...73753ee. Read the comment docs.

Copy link
Collaborator

@zoomchan-cxj zoomchan-cxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoomchan-cxj zoomchan-cxj merged commit 21d8b58 into Tencent:master Nov 3, 2020
@xuqingkuang xuqingkuang deleted the fix/vue-div-focus branch November 3, 2020 02:19
boxizen pushed a commit to boxizen/Hippy that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants