Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): fix jsc call c crash #4184

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

etkmao
Copy link
Collaborator

@etkmao etkmao commented Feb 13, 2025

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@github-actions github-actions bot added driver: js size: s Denotes a PR that changes 10-99 lines labels Feb 13, 2025
Copy link

hippy-service bot commented Feb 13, 2025

Hi, @etkmao. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@etkmao etkmao requested a review from wwwcg February 13, 2025 06:46
@wwwcg wwwcg force-pushed the bugfix/fix_jsc_call_c_crash branch from 6404a29 to df7b180 Compare February 13, 2025 07:02
@etkmao etkmao enabled auto-merge (squash) February 13, 2025 07:58
@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ etkmao
❌ open-hippy
You have signed the CLA already but the status is still pending? Let us recheck it.

@etkmao etkmao requested a review from wwwcg February 13, 2025 08:42
@etkmao etkmao disabled auto-merge February 13, 2025 08:47
@etkmao etkmao merged commit 743f6d0 into Tencent:main Feb 13, 2025
16 of 25 checks passed
wwwcg pushed a commit to wwwcg/Hippy that referenced this pull request Feb 14, 2025
wwwcg pushed a commit that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
driver: js size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants