fix(hippy-react-web): fixed image newProps src unRendered problem #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ooo/Hippy into fix/hippy-react-web-image
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
=======================================
Coverage 59.42% 59.42%
=======================================
Files 25 25
Lines 1676 1676
=======================================
Hits 996 996
Misses 680 680 Continue to review full report at Codecov.
|
zoomchan-cxj
approved these changes
Dec 31, 2020
| @@ -100,6 +100,8 @@ export class Image extends React.Component { | |||
| super(props); | |||
| this.state = { | |||
| isLoadSuccess: false, | |||
| imageUrl: props.source ? props.source.uri : '', | |||
| prevImageUrl: props.source ? props.source.uri : '', | |||
There was a problem hiding this comment.
props.source ? props.source.uri : '' 重复了写了两次，可以精简圈复杂度
zoomchan-cxj
pushed a commit
that referenced
this pull request
Jan 4, 2021
* fix(hippy-react-web): fixed image newProps src unRendered problem * fix(hippy-react-web): fixed eslint problem * fix(hippy-react-web): use getDerivedStateFromProps replace componentWillReceiveProps * fix(hippy-react-web): life cycle replace * chore(hippy-react-web): optimize the code
boxizen
pushed a commit
to boxizen/Hippy
that referenced
this pull request
Aug 16, 2021
…ncent#472) * fix(hippy-react-web): fixed image newProps src unRendered problem * fix(hippy-react-web): fixed eslint problem * fix(hippy-react-web): use getDerivedStateFromProps replace componentWillReceiveProps * fix(hippy-react-web): life cycle replace * chore(hippy-react-web): optimize the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a new pull request, please make sure: