Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): fix viewpager onpagescroll and onpageselected event #761

Merged
merged 8 commits into from
May 19, 2021
Merged

fix(ios): fix viewpager onpagescroll and onpageselected event #761

merged 8 commits into from
May 19, 2021

Conversation

ozonelmy
Copy link
Contributor

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline.
  • Squash the repeat code commits, short patches are welcome.

@ozonelmy ozonelmy requested review from lgyhero and zoomchan-cxj May 18, 2021 03:27
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2021 •
edited
Loading

Codecov Report

Merging #761 (e736fc3) into master (25f7033) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   60.05%   60.05%           
=======================================
  Files          26       26           
  Lines        1675     1675           
=======================================
  Hits         1006     1006           
  Misses        669      669

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f7033...e736fc3. Read the comment docs.

@ozonelmy ozonelmy closed this May 19, 2021
@ozonelmy ozonelmy reopened this May 19, 2021
lgyhero
lgyhero approved these changes May 19, 2021
View reviewed changes
Copy link

@lgyhero lgyhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozonelmy ozonelmy merged commit ddfd63e into master May 19, 2021
@ozonelmy ozonelmy deleted the bugfix/viewpager_on_page_event branch May 19, 2021 09:58
zoomchan-cxj pushed a commit that referenced this pull request May 19, 2021
@ozonelmy @zoomchan-cxj
fix(ios): fix viewpager onpagescroll and onpageselected event (#761)
1a50294 
* fix(ios): fix viewpager onpagescroll and onpageselected event
boxizen pushed a commit to boxizen/Hippy that referenced this pull request Aug 16, 2021
@ozonelmy @boxizen
fix(ios): fix viewpager onpagescroll and onpageselected event (Tencen…
abe3725 
…t#761)

* fix(ios): fix viewpager onpagescroll and onpageselected event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgyhero lgyhero lgyhero approved these changes

@zoomchan-cxj zoomchan-cxj Awaiting requested review from zoomchan-cxj

@churchill-zhang churchill-zhang Awaiting requested review from churchill-zhang

@ilikethese ilikethese Awaiting requested review from ilikethese

@siguangli siguangli Awaiting requested review from siguangli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ozonelmy @codecov-commenter @lgyhero @zoomchan-cxj