Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doc about vulkan-sdk #5911

Merged
merged 1 commit into from
Feb 19, 2025
Merged

update doc about vulkan-sdk #5911

merged 1 commit into from
Feb 19, 2025

Conversation

nihui
Copy link
Member

@nihui nihui commented Feb 19, 2025

No description provided.

@nihui nihui requested a review from Copilot February 19, 2025 10:46
@github-actions github-actions bot added the doc label Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (5)

docs/faq.en.md:46

  • The phrase 'the dir ncnnConfig.cmake exist' should be 'the directory where ncnnConfig.cmake exists'.
set(ncnn_DIR { the dir ncnnConfig.cmake exist})

docs/faq.en.md:48

  • The placeholder 'xxx.lib' is not very descriptive. It should be replaced with a more specific placeholder or explanation.
## xxx.lib not found(be specified by system/compiler)

docs/faq.en.md:53

  • The phrase 'need vulkan-1.lib' should be 'needs vulkan-1.lib'.
need vulkan-1.lib

docs/faq.en.md:55

  • The phrase 'need glslang.lib OGLCompiler.lib SPIRV.lib OSDependent.lib' should be 'needs glslang.lib, OGLCompiler.lib, SPIRV.lib, and OSDependent.lib'.
need glslang.lib OGLCompiler.lib SPIRV.lib OSDependent.lib

docs/faq.md:56

  • [nitpick] The term 'glslang-default-resource-limits.lib' might be unclear to some users. Consider providing a brief explanation or context for this library.
需要 glslang.lib glslang-default-resource-limits.lib
@nihui nihui merged commit 2535a6d into Tencent:master Feb 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant