Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api to parse string with specified length #417

Closed
wants to merge 3 commits into from
Closed

Add api to parse string with specified length #417

wants to merge 3 commits into from

Conversation

dackon
Copy link

@dackon dackon commented Aug 31, 2015

Added new BufferStream to parse string.
issue 415

@pah
Copy link
Contributor

pah commented Aug 31, 2015

Great 👍, this one closes the first third of #158.

For completeness, an insitu variant (with a GenericInsituBufferStream) and an overload for std::string could be added. The latter has been sketched in #158 (comment) already.

Thanks!

@miloyip
Copy link
Collaborator

miloyip commented Sep 1, 2015

Oh... I really forgot about MemoryStream, which should be used instead.
Besides, we need to add the APIs and some unit tests on this.

@dackon
Copy link
Author

dackon commented Sep 1, 2015

Yes, MemoryStream is good enough for my case. I'll add the api in my fork. Thanks. And I'll not send the pull request because it doesn't deal with the encoding. Sorry.

@dackon dackon closed this Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants