Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the ratelimit bug for 2022 #1314

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Conversation

fredrikliu
Copy link
Contributor

@fredrikliu fredrikliu commented Jun 6, 2024

PR Type

Describe what this PR does for and how you did.

Adding the issue link (#xxx) if possible.

Note

Checklist

  • Add information of this PR to CHANGELOG.md in root of project.
  • Add documentation in javadoc or comment below the PR if necessary.

Checklist (Optional)

  • Will pull request to branch of 2023.0.
  • Will pull request to branch of 2022.0.
  • Will pull request to branch of 2021.0.
  • Will pull request to branch of 2020.0.
  • Will pull request to branch of hoxton.

SkyeBeFreeman
SkyeBeFreeman previously approved these changes Jun 6, 2024
@fredrikliu fredrikliu changed the title fix the ratelimit bug for hoxton fix the ratelimit bug for 2022 Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.60%. Comparing base (e585329) to head (c13b9e7).
Report is 2 commits behind head on 2022.0.

Current head c13b9e7 differs from pull request most recent head 500f950

Please upload reports for the commit 500f950 to get more accurate results.

Files Patch % Lines
...ris/ratelimit/filter/QuotaCheckReactiveFilter.java 50.00% 1 Missing ⚠️
...aris/ratelimit/filter/QuotaCheckServletFilter.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             2022.0    #1314      +/-   ##
============================================
- Coverage     76.62%   76.60%   -0.03%     
  Complexity     1799     1799              
============================================
  Files           274      274              
  Lines          6388     6390       +2     
  Branches        781      781              
============================================
  Hits           4895     4895              
- Misses         1063     1064       +1     
- Partials        430      431       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SkyeBeFreeman SkyeBeFreeman merged commit e99dbe8 into Tencent:2022.0 Jun 6, 2024
4 checks passed
@SkyeBeFreeman SkyeBeFreeman added this to the 2.0.0.0 milestone Jul 2, 2024
fuyuwei01 pushed a commit to fuyuwei01/spring-cloud-tencent that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants