Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dialog): resolved closeOnOverlayClick is invalid in command #3066

Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix(Dialog): resolved closeOnOverlayClick is invalid in command #3066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/dialog/_example/command/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Component({
const dialogConfig = {
context: this,
title: '弹窗标题',
closeOnOverlayClick: true,
content: '告知当前状态、信息和解决方法等内容。',
confirmBtn: '确定',
cancelBtn: '取消',
Expand Down
1 change: 1 addition & 0 deletions src/dialog/dialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ export default class Dialog extends SuperComponent {
overlayClick() {
if (this.properties.closeOnOverlayClick) {
this.triggerEvent('close', { trigger: 'overlay' });
this.close();
}
this.triggerEvent('overlay-click');
},
Expand Down
Loading