Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dialog): during function calls, the close button is not working properly #1513

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

QuentinHsu
Copy link
Contributor

@QuentinHsu QuentinHsu commented Jul 26, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

fix #1477

💡 需求背景和解决方案

onClose 事件应该只是隐藏 DOM,而不是移除 DOM

📝 更新日志

  • fix(Dialog): 修复函数式调用 Dialog 时关闭按钮不生效

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

完成

@QuentinHsu QuentinHsu changed the title fix(dialog): during function calls, the close button is not working properly fix(Dialog): during function calls, the close button is not working properly Jul 29, 2024
@anlyyao anlyyao merged commit 4dcd95d into Tencent:develop Aug 7, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Aug 8, 2024
@QuentinHsu QuentinHsu deleted the fix-dialog-function-call branch August 14, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dialog] 命令行调用时closeBtn: true关闭按钮不生效
2 participants