Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactRender): fix React19 reactRender error #3380

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

HaixingOoO
Copy link
Collaborator

@HaixingOoO HaixingOoO commented Feb 23, 2025

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

React18和19导出createRoot是在react-dom/client中的;
为了兼容React17的reactRender,导出createRoot是在react-dom中的;

是否还要兼容React17及以下的渲染?
现在这种写法是为了兼容的,不兼容的话就改成react-dom/client现代的写法来处理

📝 更新日志

  • fix(reactRender): fix React19 reactRender error

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

完成

@uyarn uyarn merged commit af2d1a8 into develop Feb 24, 2025
9 checks passed
@uyarn uyarn deleted the fix/react19/react-render branch February 24, 2025 06:32
@github-actions github-actions bot mentioned this pull request Feb 28, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants