fix(table): fix footer render when using virtual scroll #3383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangchen1031
requested review from
honkinglin,
uyarn,
carolin913,
HaixingOoO,
NWYLZW and
ZWkang
as code owners
|
|
|
/update-snapshot |
|
⏳ 正在运行快照更新。。。 CI: Open |
uyarn
changed the title
uyarn
approved these changes
Feb 26, 2025
| @@ -472,7 +473,7 @@ const BaseTable = forwardRef<BaseTableRef, BaseTableProps>((originalProps, ref) | |||
| pagination: innerPagination, | |||
| }; | |||
|
|
|||
| const translate = `translate(0, ${virtualConfig.scrollHeight}px)`; | |||
| const translate = `translate(0, ${virtualConfig.scrollHeight + affixHeaderHeight + tableFootHeight}px)`; | |||
There was a problem hiding this comment.
这里要看 出现了undefined 和 NaN 的情况
Wesley-0808
added a commit
to Wesley-0808/tdesign-react
that referenced
this pull request
Mar 3, 2025
commit dd4c832 Author: wū yāng <[email protected]> Date: Sun Mar 2 15:19:16 2025 +0800 chore: change docs file path (Tencent#3403) commit 071c4b8 Author: wū yāng <[email protected]> Date: Sun Mar 2 15:04:50 2025 +0800 refactor: mono repo move src to packages/components (Tencent#3402) * chore: remove old submodule * refactor: add new submodule * refactor: add new submodule * refactore: move src to packages/components * refactor: mono repo * refactor: site rerun * refactor: test rerun * refactor: fix build commit 9a0b6ac Author: Haixing <[email protected]> Date: Fri Feb 28 16:59:07 2025 +0800 Release: 1.11.1 (Tencent#3393) * release/1.11.1 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit bfc06a6 Author: wū yāng <[email protected]> Date: Fri Feb 28 16:25:28 2025 +0800 fix: fix cjs bundle (Tencent#3392) commit b15b142 Author: liweijie0812 <[email protected]> Date: Wed Feb 26 16:21:35 2025 +0800 feat(Content): support content api (Tencent#3384) commit 0cc866b Author: huangchen1031 <[email protected]> Date: Wed Feb 26 16:21:12 2025 +0800 fix(Table): fix footer render when using virtual scroll (Tencent#3383) * fix(table): 修复虚拟滚动下的footer渲染问题 * chore: update snapshots * chore: update snapshots * chore: update snapshot --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Merge branch 'develop' into feat/drawerPlugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
1、开启虚拟滚动时，footer不会固定在底部。
2、同时开启
footerAffixedBottom时，footer会滚动到视野内，并且无法滚动到最后一行。修改前：
修改后：
来源：#3142
参考：Tencent/tdesign-vue-next#3965
📝 更新日志
fix(table): 修复虚拟滚动下的footer渲染问题
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单