Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Component: TagInput #131

Merged
merged 36 commits into from
Jan 20, 2022
Merged

New Component: TagInput #131

merged 36 commits into from
Jan 20, 2022

Conversation

chaishi
Copy link
Collaborator

@chaishi chaishi commented Jan 3, 2022 •
edited
Loading

子仓库样式变更：Tencent/tdesign-common#89 和 Tencent/tdesign-common#140

CR 的时候重点关注 Input 和 TagInput

本次变更内容

  • TagInput：新组件
  • Input: 新增 tips onMouseenter onMouseleave onPaste 等 API

image

@chaishi chaishi mentioned this pull request Jan 3, 2022
Merged
@chaishi chaishi changed the title New Component: TagInput [WIP]New Component: TagInput Jan 3, 2022
@Tencent Tencent deleted a comment from PengYYYYY Jan 11, 2022
@Tencent Tencent deleted a comment from PengYYYYY Jan 11, 2022
@Tencent Tencent deleted a comment from PengYYYYY Jan 11, 2022
@chaishi chaishi changed the title [WIP]New Component: TagInput New Component: TagInput Jan 18, 2022
@Tencent Tencent deleted a comment from PengYYYYY Jan 18, 2022
@Tencent Tencent deleted a comment from PengYYYYY Jan 18, 2022
@xiaosansiji
Copy link
Collaborator

image
有改动到 tree-select 么？看起来 test 失败了

@chaishi
Copy link
Collaborator Author

chaishi commented Jan 18, 2022

@xiaosansiji 没改啥，就是加了些 Demo 测试用例

@chaishi
Copy link
Collaborator Author

chaishi commented Jan 19, 2022

预览地址： https://preview-pr131-tdesign-vue-next.surge.sh

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2022 •
edited
Loading

PR 预览产物在 https://preview-pr131-tdesign-vue-next.surge.sh

@94dreamer 94dreamer closed this Jan 19, 2022
@94dreamer 94dreamer reopened this Jan 19, 2022
@PengYYYYY
Copy link
Collaborator

我把流程给到设计那边评审一下

@chaishi
Copy link
Collaborator Author

chaishi commented Jan 19, 2022

@josonyang 666，下次试试

PengYYYYY
PengYYYYY approved these changes Jan 20, 2022
View reviewed changes
Copy link
Collaborator

@PengYYYYY PengYYYYY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PengYYYYY PengYYYYY merged commit 76777da into Tencent:develop Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PengYYYYY PengYYYYY PengYYYYY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chaishi @xiaosansiji @PengYYYYY @josonyang @94dreamer