Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refact/menu collapse animation #3140

Merged
merged 7 commits into from
Jul 26, 2023
Merged

Refact/menu collapse animation #3140

merged 7 commits into from
Jul 26, 2023

Conversation

xiaosansiji
Copy link
Collaborator

@xiaosansiji xiaosansiji commented Jul 24, 2023 •
edited by PengYYYYY
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

vue2 修改:Tencent/tdesign-vue#2561

重构前：
Kapture 2023-07-25 at 15 24 31

重构后动效与 Collapse 组件展开/收起效果一样：
Kapture 2023-07-25 at 15 26 20

📝 更新日志

  • refactor(Menu): 重构侧边栏导航子菜单展开/收起动画实现，修复 SubMenu 菜单项过多时无法完整展示的问题 (issues #2262)

  • fix(Menu): 修复 MenuItem click 点击事件未传递 event 参数的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023 •
edited
Loading

完成

@xiaosansiji xiaosansiji changed the title [WIP]Refact/menu collapse animation Refact/menu collapse animation Jul 25, 2023
@xiaosansiji xiaosansiji mentioned this pull request Jul 25, 2023
Closed
16 tasks
@PengYYYYY PengYYYYY merged commit 1e9d0ac into develop Jul 26, 2023
@PengYYYYY PengYYYYY deleted the refact/menu-collapse-animation branch July 26, 2023 06:40
This was referenced Jul 26, 2023
Closed
Merged
@hd10180 hd10180 mentioned this pull request Jan 22, 2025
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PengYYYYY PengYYYYY PengYYYYY approved these changes

@chaishi chaishi Awaiting requested review from chaishi chaishi is a code owner

@honkinglin honkinglin Awaiting requested review from honkinglin honkinglin is a code owner

@LeeJim LeeJim Awaiting requested review from LeeJim LeeJim is a code owner

@uyarn uyarn Awaiting requested review from uyarn uyarn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaosansiji @PengYYYYY