Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dropdown): remove dropdown left special style #3752

Merged
merged 1 commit into from
Dec 15, 2023
Merged

feat(dropdown): remove dropdown left special style #3752

merged 1 commit into from
Dec 15, 2023

Conversation

uyarn
Copy link
Collaborator

@uyarn uyarn commented Dec 15, 2023 •
edited by PengYYYYY
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

  1. 跟进大部分用户反馈 不希望left direction的场景下将展开箭头与文案位置互换 去掉这部分特殊处理
    处理前
image

处理后
image

  1. 更新common

📝 更新日志

  • feat(Dropdown): 移除对 left 的 item 样式特殊处理

  • fix(DatePicker): 修复日期选择禁用后，后缀图标颜色改变的问题 @HaixingOoO

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions GitHub Actions
Copy link
Contributor

完成

@PengYYYYY PengYYYYY merged commit 88c69cc into develop Dec 15, 2023
7 checks passed
@PengYYYYY PengYYYYY deleted the feat/dropdown-left-style branch December 15, 2023 14:02
@github-actions github-actions bot mentioned this pull request Dec 21, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PengYYYYY PengYYYYY PengYYYYY approved these changes

@chaishi chaishi Awaiting requested review from chaishi chaishi is a code owner

@xiaosansiji xiaosansiji Awaiting requested review from xiaosansiji xiaosansiji is a code owner

@honkinglin honkinglin Awaiting requested review from honkinglin honkinglin is a code owner

@LeeJim LeeJim Awaiting requested review from LeeJim LeeJim is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uyarn @PengYYYYY