fix(Drawer):修复closeOnEscKeydown 开启时任意按键都会触发Drawer问题 #3904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanlinxin
requested review from
PengYYYYY,
chaishi,
xiaosansiji,
honkinglin,
LeeJim and
uyarn
as code owners
|
|
uyarn
approved these changes
Jan 29, 2024
Merged
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
原有逻辑下 组件的属性closeOnEscKeydown 为 true时, 判断中 ?? 运算直接命中true 跳过后续的判断
调整判断逻辑，先进行当前组件和全局的closeOnEscKeydown属性判断，再判断按键以及显示状态
📝 更新日志
fix(Drawer):修复
1.8.0中closeOnEscKeydown开启时任意按键都会触发Drawer关闭的问题本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单