Feature/color picker #408
Merged
Feature/color picker #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
PengYYYYY
reviewed
Mar 11, 2022
There was a problem hiding this comment.
几个比较重要的点先说一下：
- 去除组件的 mapprops，换成useVModel
- prefix统一取config里面的
- 事件统一用props.onXX,不用emit
另外可以看看下面这个iwiki。
https://github.com/Tencent/tdesign-vue-next/wiki/TDesign--CompositionAPI-%E5%BC%80%E5%8F%91%E8%A7%84%E8%8C%83
chaishi
reviewed
Mar 16, 2022
chaishi
reviewed
Mar 16, 2022
|
这选到白色的时候不是很明显，估计边框颜色要加一下
|
|
透明度的显示能不能换成%，与当前认知有点不符 |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
feat(color-picker): 新增颜色选择器组件
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单