Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialog): add missing null type #4439

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

chouchouji
Copy link
Contributor

@chouchouji chouchouji commented Jul 25, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(Dialog): 修复 cancelBtnconfirmBtn 设置为null 的类型问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Jul 25, 2024

完成

@uyarn
Copy link
Collaborator

uyarn commented Jul 27, 2024

@chouchouji thanks for you PR! but didn't you reproduce it? it's normal in my IDE
image

@uyarn
Copy link
Collaborator

uyarn commented Jul 28, 2024

@chouchouji thanks for you PR! but didn't you reproduce it? it's normal in my IDE image

I see, it's because of the strictNullChecks of my tsconfig is false :)

@gangchn
Copy link

gangchn commented Jul 29, 2024

So it is look like reasonable that set null as one of property cancelBtn type, because it is a nullable property and we also explicitly describe that it can be set to null in comment.

@uyarn
Copy link
Collaborator

uyarn commented Jul 29, 2024

would you mind fixing confirmBtn as well ?

@chouchouji
Copy link
Contributor Author

would you mind fixing confirmBtn as well ?

I will complete it. Thanks for your review!

@chouchouji
Copy link
Contributor Author

would you mind fixing confirmBtn as well ?

done

@uyarn uyarn merged commit bbb87a7 into Tencent:develop Jul 30, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants