Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/collapse #571

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Feature/collapse #571

merged 2 commits into from
Apr 12, 2022

Conversation

asbstty
Copy link
Contributor

@asbstty asbstty commented Apr 12, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

collapse-panel的value属性如果没有提供,兜底为下标。当前的实现是在collapse父组件的render方法中遍历,如果类型是collapse-panel并且没有提供value属性,就把下标赋值给panel的value。这种实现方式在异步获取panel列表的时候有问题,所以改了一下panel value的初始化逻辑。

📝 更新日志

  • fix(collapse): 异步获取panel列表优化

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

完成

Copy link
Collaborator

@uyarn uyarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uyarn uyarn merged commit 04a2847 into Tencent:develop Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants