Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support close popup when double click input area #1215

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

xiaosansiji
Copy link
Collaborator

@xiaosansiji xiaosansiji commented Jul 26, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

Tencent/tdesign-react#919

react 对应修改:Tencent/tdesign-react#1174
vue-next 对应修改:Tencent/tdesign-vue-next#1299

💡 需求背景和解决方案

📝 更新日志

  • feat(SelectInput): SelectInput 及相关的 Select/Cascader/TreeSelect 组件交互调整,再次点击输入框时也可以收起下拉框。

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@chaishi chaishi added the ⛔️ pending the issue won't be processed right now label Jul 26, 2022
@chaishi
Copy link
Collaborator

chaishi commented Jul 26, 2022

这个 PR 先 Hold 住,需要交互确认

之前讨论过多次,文康说交互设计如此,就是点击输入框永久显示,不需要两次点击关闭

@honkinglin
Copy link
Collaborator

这个 PR 先 Hold 住,需要交互确认

之前讨论过多次,文康说交互设计如此,就是点击输入框永久显示,不需要两次点击关闭

上周4跟设计和交互确定了,就调整为关闭

@honkinglin honkinglin merged commit f8fd57d into develop Aug 1, 2022
@honkinglin honkinglin deleted the feat/select-input-double-click branch August 1, 2022 07:59
@xiaosansiji xiaosansiji mentioned this pull request Aug 2, 2022
@github-actions github-actions bot mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛔️ pending the issue won't be processed right now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants