Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): 列宽度和小于表宽的情况下,调整列宽的结果与预期不符 #1225

Merged
merged 18 commits into from
Aug 1, 2022

Conversation

ZTao-z
Copy link
Contributor

@ZTao-z ZTao-z commented Jul 29, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#1067

💡 需求背景和解决方案

  1. 使用thWidthList记录拖动后的实际列宽
  2. 根据拖动结果重新计算其余各列的宽度,使之能够确保列宽总和大于等于表宽

📝 更新日志

  • fix(table): 列宽度和小于表宽的情况下,调整列宽的结果与预期不符,issue#1067

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2022

完成

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #1225 (eeb4b47) into develop (aaf0135) will decrease coverage by 0.69%.
The diff coverage is 21.32%.

@@             Coverage Diff             @@
##           develop    #1225      +/-   ##
===========================================
- Coverage    58.80%   58.11%   -0.70%     
===========================================
  Files          405      407       +2     
  Lines        15051    15310     +259     
  Branches      2844     2907      +63     
===========================================
+ Hits          8851     8897      +46     
- Misses        5927     6138     +211     
- Partials       273      275       +2     
Impacted Files Coverage Δ
src/date-picker/DatePicker.tsx 26.13% <ø> (ø)
src/date-picker/DateRangePicker.tsx 15.28% <0.00%> (-0.51%) ⬇️
src/date-picker/hooks/useRange.ts 36.58% <0.00%> (+0.44%) ⬆️
src/date-picker/hooks/useSingle.ts 37.28% <0.00%> (-2.00%) ⬇️
src/date-picker/panel/PanelContent.tsx 36.36% <ø> (ø)
src/table/base-table-props.ts 61.53% <ø> (ø)
src/table/editable-cell.tsx 7.03% <0.00%> (-2.41%) ⬇️
src/table/hooks/tree-store.ts 10.14% <0.00%> (-0.25%) ⬇️
src/table/hooks/useClassName.ts 100.00% <ø> (ø)
src/table/thead.tsx 88.09% <0.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1e37bd...eeb4b47. Read the comment docs.

@chaishi
Copy link
Collaborator

chaishi commented Jul 29, 2022

吸顶表头里面的应用,会出现一些问题

2022-07-29.16.02.13.mov

@chaishi chaishi merged commit 7806708 into Tencent:develop Aug 1, 2022
@github-actions github-actions bot mentioned this pull request Aug 3, 2022
@ZTao-z ZTao-z deleted the fix/table branch August 14, 2022 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants