Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(color-picker): 修复color-picker 切换模式卡死问题; 修复panel模式@change事件无法触发问题 #1274

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

S-mohan
Copy link
Contributor

@S-mohan S-mohan commented Aug 11, 2022

fix #1268

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(color-picker): 修复color-picker 切换模式卡死问题; 修复panel模式@change事件无法触发问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@codecov-commenter
Copy link

Codecov Report

Merging #1274 (96f98bc) into develop (492d477) will increase coverage by 0.29%.
The diff coverage is 41.92%.

@@             Coverage Diff             @@
##           develop    #1274      +/-   ##
===========================================
+ Coverage    57.94%   58.23%   +0.29%     
===========================================
  Files          407      408       +1     
  Lines        15371    15287      -84     
  Branches      2931     2881      -50     
===========================================
- Hits          8907     8903       -4     
+ Misses        6187     6108      -79     
+ Partials       277      276       -1     
Impacted Files Coverage Δ
src/cascader/cascader.tsx 64.00% <ø> (ø)
src/color-picker/color-picker.tsx 81.25% <ø> (ø)
src/date-picker/DatePicker.tsx 26.74% <ø> (ø)
src/date-picker/DateRangePicker.tsx 15.82% <ø> (ø)
src/date-picker/date-picker-panel-props.ts 100.00% <ø> (+90.00%) ⬆️
src/date-picker/date-range-picker-panel-props.ts 100.00% <ø> (+90.90%) ⬆️
src/date-picker/date-range-picker-props.ts 42.85% <0.00%> (-11.69%) ⬇️
src/date-picker/hooks/useRange.ts 35.89% <ø> (ø)
src/date-picker/hooks/useSingle.ts 37.28% <ø> (ø)
src/date-picker/hooks/useTableData.ts 17.64% <ø> (ø)
... and 44 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

完成

@chaishi chaishi merged commit a55e0ed into Tencent:develop Aug 11, 2022
@github-actions github-actions bot mentioned this pull request Aug 16, 2022
@S-mohan S-mohan deleted the feature/color-picker branch November 17, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ColorPicker] 颜色选择器面板使用@change事件无效,但onChange属性可以生效
3 participants