Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 更新button的示例代码 用space组件替换 减少重复代码 #1334

Merged
merged 7 commits into from
Aug 23, 2022

Conversation

Tomaolala
Copy link
Contributor

@Tomaolala Tomaolala commented Aug 19, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • chore: 更新Button 示例代码

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@Tomaolala Tomaolala changed the title chore: 更新button的示例代码 用space组件替换 减少重复代码 修复虚拟滚动代码示例 chore: 更新button的示例代码 用space组件替换 减少重复代码 Aug 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2022

完成

@Tomaolala
Copy link
Contributor Author

@uyarn
image
应该没问题了

@codecov-commenter
Copy link

Codecov Report

Merging #1334 (c92fe59) into develop (492d477) will increase coverage by 0.32%.
The diff coverage is 70.09%.

@@             Coverage Diff             @@
##           develop    #1334      +/-   ##
===========================================
+ Coverage    57.94%   58.27%   +0.32%     
===========================================
  Files          407      412       +5     
  Lines        15371    15373       +2     
  Branches      2931     2895      -36     
===========================================
+ Hits          8907     8958      +51     
+ Misses        6187     6144      -43     
+ Partials       277      271       -6     
Impacted Files Coverage Δ
src/button/props.ts 84.61% <0.00%> (-15.39%) ⬇️
src/calendar/const.ts 100.00% <ø> (ø)
src/cascader/cascader.tsx 64.00% <ø> (ø)
src/color-picker/color-picker.tsx 81.25% <ø> (ø)
src/color-picker/panel/header.tsx 69.56% <ø> (-1.27%) ⬇️
src/date-picker/base/Header.tsx 7.57% <0.00%> (-0.37%) ⬇️
src/date-picker/date-picker-panel-props.ts 100.00% <ø> (+90.00%) ⬆️
src/date-picker/date-range-picker-panel-props.ts 100.00% <ø> (+90.90%) ⬆️
src/date-picker/date-range-picker-props.ts 42.85% <0.00%> (-11.69%) ⬇️
src/date-picker/hooks/useRange.ts 35.89% <ø> (ø)
... and 162 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@uyarn
Copy link
Collaborator

uyarn commented Aug 21, 2022

image

这个div也可以去掉吧

@Tomaolala
Copy link
Contributor Author

@uyarn 之前有点忙,抱歉

Copy link
Collaborator

@uyarn uyarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uyarn uyarn merged commit b044b16 into Tencent:develop Aug 23, 2022
@github-actions github-actions bot mentioned this pull request Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants