Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cascader-panel): 点击选项时派发 click 事件 #1396

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

luwuer
Copy link
Contributor

@luwuer luwuer commented Aug 28, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#1389

💡 需求背景和解决方案

现有特性下,如果用户想要自定义 cascader 的表现,只能根据 cascader-panel 派发的 change 事件处理 panel 的显示和隐藏,但在单选模式下点击已选择项 change 事件是不会被触发的,此时用户没有一种方式能感知到操作已经发生,所以没办法比较方便地维护自定义组件的状态。

PR 通过点击 cascader-panel 选项时派发点击事件 click,实现用户对 panel 状态的感知

📝 更新日志

  • feat(CascaderPanel): 点击选项时派发 click 事件

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@codecov-commenter
Copy link

Codecov Report

Merging #1396 (872a2a9) into develop (492d477) will decrease coverage by 14.59%.
The diff coverage is 67.62%.

@@             Coverage Diff              @@
##           develop    #1396       +/-   ##
============================================
- Coverage    57.94%   43.35%   -14.60%     
============================================
  Files          407      759      +352     
  Lines        15371    20839     +5468     
  Branches      2931     2968       +37     
============================================
+ Hits          8907     9035      +128     
- Misses        6187    11524     +5337     
- Partials       277      280        +3     
Impacted Files Coverage Δ
src/affix/_tests_/demo.test.js 0.00% <ø> (ø)
src/affix/_tests_/index.test.js 0.00% <ø> (ø)
src/alert/_example/icon.vue 100.00% <ø> (ø)
src/alert/_tests_/demo.test.js 0.00% <ø> (ø)
src/alert/_usage/index.vue 0.00% <ø> (ø)
src/anchor/_tests_/anchor-link.test.js 0.00% <0.00%> (ø)
src/anchor/_tests_/anchor-target.test.js 0.00% <0.00%> (ø)
src/anchor/_tests_/demo.test.js 0.00% <ø> (ø)
src/anchor/_tests_/index.test.js 0.00% <0.00%> (ø)
src/anchor/_usage/index.vue 0.00% <ø> (ø)
... and 606 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

完成

@PengYYYYY PengYYYYY merged commit 569607c into Tencent:develop Aug 29, 2022
@github-actions github-actions bot mentioned this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants