fix(Transfer): 修复设置pageSizeOptions时切换pageSize无法生效得问题 #3374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningbao
requested review from
chaishi,
uyarn,
xiaosansiji,
maoyiluo,
liweijie0812 and
LoopZhou
as code owners
|
|
uyarn
approved these changes
Nov 18, 2024
Merged
16 tasks
uyarn
pushed a commit
that referenced
this pull request
Dec 6, 2024
uyarn
added a commit
that referenced
this pull request
Dec 6, 2024
* feat(icons): new version (#3392) * feat(Dialog&Drawer): support beforeOpen And beforeClose API (#3393) chore: docs * chore: replace version request (#3394) * fix(Transfer): 修复设置pageSizeOptions时切换pageSize无法生效得问题 (#3374) * docs(Transfer): update desc (#3398) * fix(input-number): limiting the input of numbers exceeding the range does not trigger the blur event (#3399) * fix(Space): fixed template white space bugs (#3401) * fix(TimePicker): fixed only support hh:mm format * fix(TimePicker): disabled position only is start * fix(Upload): fixed vue error on uploadPastedFiles is false * docs: add readonly in api * fix: fixed template white space bugs * chore: update snap * chore(deps): bump tdesign-icons-vue from 0.2.5 to 0.3.2 (#3408) --- updated-dependencies: - dependency-name: tdesign-icons-vue dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(Select): 增加option cache，避免搜索过滤时optionsList为空导致选中选项显示异常 (#3410) * feat(Form): form rule support multi trigger (#3323) * fix(TimePicker): fixed only support hh:mm format * fix(TimePicker): disabled position only is start * fix(Upload): fixed vue error on uploadPastedFiles is false * docs: add readonly in api * feat(Form): rule support array trigger * fix(transfer): fix tree disabled and drag sort bug (#3412) * fix(transfer): fix tree disabled and drag sort bug * chore: revert demo change * fix(Table): fixed treeNodeCol not update on columns change (#3400) * fix(TimePicker): fixed only support hh:mm format * fix(TimePicker): disabled position only is start * fix(Upload): fixed vue error on uploadPastedFiles is false * docs: add readonly in api * fix(Table): fixed treeNodeCol not update on columns change * fix(Slider): fix controlled usage (#3414) * fix(Slider): fix controlled usage * fix(Slider): fix default usage * chore: remove incorrect unit test * chore: add unit test * chore: add unit test * feat(tree): support scroll instance function and key param (#3415) * feat(DatePicker): support multiple API (#3407) * fix(datepicker): 增加多选模式 fix #3341 * refactor(datepicker): 修复props类型告警 * chore: update snapshot and fix type * chore: update snapshot and fix type * chore: fix render * chore: fix type * chore: fix * chore: fix * chore: update snapshot and fix type --------- Co-authored-by: Uyarn <[email protected]> * chore: release 1.10.6 (#3416) * Update package.json * chore: changelog's changes * chore: fix info --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: release 1.10.6-naruto * chore: release 1.10.6-naruto --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Wesley <[email protected]> Co-authored-by: MorningUei <[email protected]> Co-authored-by: betavs <[email protected]> Co-authored-by: myron <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: hkaikai <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
#3268
💡 需求背景和解决方案
transfer-list组件内会接收page得参数pageSizeOptions，但由于使用??语法得问题(只有null以及undefined时才会继续往右取值)，this.defaultPageSize又设置为0，所以computed的pageSize一直为0，所以把defaultPageSize初始值设置为null就正常了。defaultCurrent也是同理，会导致外部传进来的pagination.defaultCurrent一直无法生效，所以一并改正。
📝 更新日志
☑️ 请求合并前的自查清单