fix(auto-complete): options is an empty array, empty is not effective #3474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liweijie0812
requested review from
chaishi,
uyarn,
xiaosansiji,
maoyiluo and
LoopZhou
as code owners
|
|
liweijie0812
force-pushed
the
fix/auto-complete
branch
from
300e658 to
e1a64f1
Compare
|
这个变更需要慎重，和设计师再对一下交互。 |
chaishi
reviewed
Jan 25, 2025
这个已经和设计同学确认过的 设计同学的角度是如果不展示任何内容 没有反馈也不合理 |
uyarn
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
options = [], 点击 没展示 empty 节点
修改后
📝 更新日志
fix(AutoComplete): 修复
options为空数组，empty 节点没显示本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单