Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tree-select): 支持treeProps.keys.children字段配置 #890

Merged
merged 2 commits into from
May 19, 2022

Conversation

LoopZhou
Copy link
Collaborator

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

Fixes #888

💡 需求背景和解决方案

配置treeProps.keys的children为自定义值。选中子节点, 选中展示的是value值, 应该展示label。
经排查是tree-select未支持自定义的treeProps.keys.children配置

📝 更新日志

  • fix(tree-select): 支持treeProps.keys.children字段配置

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2022

完成

@codecov-commenter
Copy link

Codecov Report

Merging #890 (5cbe303) into develop (a0db0df) will increase coverage by 3.12%.
The diff coverage is 67.81%.

@@             Coverage Diff             @@
##           develop     #890      +/-   ##
===========================================
+ Coverage    57.56%   60.68%   +3.12%     
===========================================
  Files          346      355       +9     
  Lines        12828    13602     +774     
  Branches      2405     2592     +187     
===========================================
+ Hits          7384     8254     +870     
+ Misses        5200     5089     -111     
- Partials       244      259      +15     
Impacted Files Coverage Δ
src/avatar/group.tsx 97.14% <ø> (ø)
src/breadcrumb/breadcrumb-item-props.ts 100.00% <ø> (ø)
src/calendar/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/cascader/props.ts 91.66% <ø> (ø)
src/cascader/utils/inputContent.ts 59.45% <0.00%> (+6.68%) ⬆️
src/date-picker/date-picker.tsx 46.57% <0.00%> (+0.72%) ⬆️
src/date-picker/panel/date-range.tsx 7.48% <0.00%> (+0.29%) ⬆️
src/dialog/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/dropdown/dropdown-menu.tsx 18.42% <ø> (ø)
src/dropdown/dropdown.tsx 70.00% <0.00%> (+5.00%) ⬆️
... and 137 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b60005...5cbe303. Read the comment docs.

@uyarn uyarn merged commit 1a31c58 into Tencent:develop May 19, 2022
@github-actions github-actions bot mentioned this pull request May 20, 2022
@LoopZhou LoopZhou deleted the fix/loopzhou-tree-select branch August 3, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants