Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: select基于select-input实现，并使用compositionAPI开发 #905

Merged
merged 10 commits into from
Jun 9, 2022
Merged

refactor: select基于select-input实现，并使用compositionAPI开发 #905

merged 10 commits into from
Jun 9, 2022

Conversation

skytt
Copy link
Contributor

@skytt skytt commented May 23, 2022 •
edited by uyarn
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • refactor(Select): 更换compositionAPI实现，更换为使用select-input构建

  • fix(Select): inputProps透传无效

  • fix(Select): placeholder无法设置空字符串

  • fix(Select): 单选无法使用valueDisplay的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2022 •
edited
Loading

失败

@skytt
Copy link
Contributor Author

skytt commented May 23, 2022 •
edited
Loading

现 select、select-panel、option、option-group 已经转为 composition API 代码，组件主体逻辑基于 select-input 开发，当前处于补齐功能的阶段，并尽可能复用现有逻辑。
TODOs:

  • inputvalue 相关逻辑
  • 支持 clearable 可清空及完善相关逻辑
  • select-input 事件处理
  • 自定义折叠渲染
  • 支持条目筛选，及相应逻辑
  • 支持创建条目，及相应逻辑
  • 远程搜索部分
  • 键盘事件响应处理

@uyarn
Copy link
Collaborator

uyarn commented May 23, 2022 •
edited
Loading

  • 接入虚拟滚动

@uyarn
Copy link
Collaborator

uyarn commented May 26, 2022

fix #862

@uyarn uyarn added the WIP work in progress label Jun 1, 2022
@uyarn
Copy link
Collaborator

uyarn commented Jun 2, 2022

fix #939

@uyarn
Copy link
Collaborator

uyarn commented Jun 7, 2022

fix #959

@uyarn uyarn removed the WIP work in progress label Jun 9, 2022
@uyarn uyarn changed the title [WIP] refactor: select基于select-input实现，并使用compositionAPI开发 refactor: select基于select-input实现，并使用compositionAPI开发 Jun 9, 2022
@uyarn
Copy link
Collaborator

uyarn commented Jun 9, 2022

  • 接入虚拟滚动

另提PR合并

@uyarn
Copy link
Collaborator

uyarn commented Jun 9, 2022

preview address: https://preview-pr905-tdesign-vue.surge.sh/vue/components/select

@uyarn uyarn merged commit acebc1e into Tencent:develop Jun 9, 2022
@github-actions github-actions bot mentioned this pull request Jun 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uyarn uyarn uyarn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skytt @uyarn