Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]Makefile中使用了bash内置[[导致在/bin/sh指向dash时报错 #57

Closed
3 tasks done
chnliyong opened this issue Jun 27, 2019 · 1 comment
Closed
3 tasks done

[bug]Makefile中使用了bash内置[[导致在/bin/sh指向dash时报错 #57

chnliyong opened this issue Jun 27, 2019 · 1 comment
Assignees
@DeveloperJim
Labels
bug Something isn't working confirmed issue is confirmed discussion issue is under dicussion enhancement New feature or request outer issue comes from others
Milestone
1.13.x功能迭代

Comments

@chnliyong
Copy link

chnliyong commented Jun 27, 2019 •
edited by DeveloperJim
Loading

问题描述

在构建执行make命令时报错

if [[ ! -d ./vendor/github.com/sirupsen ]]; then ln -sf ./vendor/github.com/Sirupsen ./vendor/github.com/sirupsen; fi
/bin/sh: 1: [[: not found
if [[ ! -d ./vendor/github.com/Sirupsen ]]; then ln -sf ./vendor/github.com/sirupsen ./vendor/github.com/Sirupsen; fi
/bin/sh: 1: [[: not found

重现方法

在Ubuntu系统中（默认/bin/sh -> dash）执行构建make

关键信息

Makefile中使用了bash的内置[[，在dash中不支持，CentOS默认/bin/sh -> bash，但是Ubuntu(或者Debian)中/bin/sh -> dash，在Ubuntu中将/bin/sh -> bash则不报错，或者将[[改成[也不报错。
请提供以下信息:

  • bk-bcs 版本:
    Version :bf46118-19.06.27
    Tag :bf46118
    BuildTime: 2019-06-27T02:02:40+0000
    GitHash: bf46118
  • 操作系统 : Ubuntu 18.04.2 LTS
  • bk-bcs 异常日志
    无
@chnliyong chnliyong added the bug Something isn't working label Jun 27, 2019
Lwxiang added a commit to Lwxiang/bk-bcs that referenced this issue Jun 28, 2019
@Lwxiang
fix: adjust scripts in makefile to avoid errors occurred in sh-based …
f1adc0b 
…shells, issue TencentBlueKing#57
Lwxiang added a commit to Lwxiang/bk-bcs that referenced this issue Jun 28, 2019
@Lwxiang
fix: change ln pwd, issue TencentBlueKing#57
73a544f
DeveloperJim added a commit that referenced this issue Jul 1, 2019
@DeveloperJim
Merge pull request #59 from Lwxiang/dev_wesley
58db993 
fix: adjust scripts in makefile, issue #57
@Lwxiang
Copy link
Collaborator

Lwxiang commented Jul 1, 2019

@chnliyong 感谢反馈，已经修复该问题

@DeveloperJim DeveloperJim added confirmed issue is confirmed discussion issue is under dicussion enhancement New feature or request outer issue comes from others labels Jul 1, 2019
@DeveloperJim DeveloperJim added this to the 1.13.x功能迭代 milestone Jul 1, 2019
@DeveloperJim DeveloperJim mentioned this issue Jul 12, 2019
Merged
DeveloperJim pushed a commit that referenced this issue Nov 4, 2019
@Lwxiang
fix: adjust scripts in makefile to avoid errors occurred in sh-based …
1b7d55b 
…shells, issue #57
DeveloperJim pushed a commit that referenced this issue Nov 4, 2019
@Lwxiang
fix: change ln pwd, issue #57
e1c6fa5
DeveloperJim added a commit that referenced this issue Nov 4, 2019
@DeveloperJim
Merge pull request #59 from Lwxiang/dev_wesley
b0ad171 
fix: adjust scripts in makefile, issue #57
ifooth added a commit to ifooth/bk-bcs that referenced this issue Apr 10, 2024
@ifooth
feat: support log level (TencentBlueKing#57)
ef2942e 
* refactor: remove print code

* feat: support log level

* feat: support log level

* feat: support log level

* feat: support log level

* feat: support log level

* feat: support log level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DeveloperJim DeveloperJim

Labels
bug Something isn't working confirmed issue is confirmed discussion issue is under dicussion enhancement New feature or request outer issue comes from others
Projects
None yet
Milestone
1.13.x功能迭代
Development

No branches or pull requests
3 participants
@chnliyong @Lwxiang @DeveloperJim