-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 分块上传优化 #2813 #2816
Open
zzdjx
wants to merge
28
commits into
TencentBlueKing:master
Choose a base branch
from
zzdjx:issue_2813
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: 分块上传优化 #2813 #2816
+1,724
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzdjx
requested review from
owenlxu
and removed request for
cnlkl,
felixncheng and
yaoxuwan
December 3, 2024 08:02
owenlxu
reviewed
Dec 4, 2024
...neric/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/controller/GenericController.kt
Outdated
Show resolved
Hide resolved
owenlxu
reviewed
Dec 4, 2024
.../common/common-mongo/src/main/kotlin/com/tencent/bkrepo/common/mongo/dao/AbstractMongoDao.kt
Outdated
Show resolved
Hide resolved
owenlxu
reviewed
Dec 4, 2024
...main/kotlin/com/tencent/bkrepo/common/artifact/repository/core/AbstractArtifactRepository.kt
Outdated
Show resolved
Hide resolved
owenlxu
reviewed
Dec 4, 2024
...ain/kotlin/com/tencent/bkrepo/common/metadata/service/blocknode/impl/BlockNodeServiceImpl.kt
Outdated
Show resolved
Hide resolved
owenlxu
reviewed
Dec 4, 2024
...kend/generic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/service/UploadService.kt
Outdated
Show resolved
Hide resolved
yaoxuwan
reviewed
Dec 10, 2024
...ackend/generic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/model/NodeAttribute.kt
Outdated
Show resolved
Hide resolved
yaoxuwan
reviewed
Dec 10, 2024
...ce/src/main/kotlin/com/tencent/bkrepo/common/metadata/service/node/impl/NodeDeleteSupport.kt
Outdated
Show resolved
Hide resolved
cnlkl
requested changes
Dec 11, 2024
...ata-service/src/main/kotlin/com/tencent/bkrepo/common/metadata/dao/blocknode/BlockNodeDao.kt
Outdated
Show resolved
Hide resolved
...ice/src/main/kotlin/com/tencent/bkrepo/common/artifact/repository/core/ArtifactRepository.kt
Outdated
Show resolved
Hide resolved
...ce/src/main/kotlin/com/tencent/bkrepo/common/metadata/service/node/impl/NodeDeleteSupport.kt
Outdated
Show resolved
Hide resolved
...metadata-service/src/main/kotlin/com/tencent/bkrepo/common/metadata/util/NodeDeleteHelper.kt
Outdated
Show resolved
Hide resolved
...biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/controller/SeparateBlockController.kt
Outdated
Show resolved
Hide resolved
...kend/generic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/service/UploadService.kt
Outdated
Show resolved
Hide resolved
...biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/controller/SeparateBlockController.kt
Show resolved
Hide resolved
...biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/controller/SeparateBlockController.kt
Outdated
Show resolved
Hide resolved
...kend/generic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/service/UploadService.kt
Show resolved
Hide resolved
...kend/generic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/service/UploadService.kt
Outdated
Show resolved
Hide resolved
zacYL
reviewed
Dec 12, 2024
...biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/controller/SeparateBlockController.kt
Outdated
Show resolved
Hide resolved
felixncheng
previously approved these changes
Dec 25, 2024
zacYL
reviewed
Dec 25, 2024
...ain/kotlin/com/tencent/bkrepo/common/metadata/service/blocknode/impl/BlockNodeServiceImpl.kt
Outdated
Show resolved
Hide resolved
zacYL
reviewed
Dec 25, 2024
...ic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/artifact/GenericLocalRepository.kt
Outdated
Show resolved
Hide resolved
zacYL
reviewed
Dec 25, 2024
...kend/generic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/service/UploadService.kt
Outdated
Show resolved
Hide resolved
cnlkl
requested changes
Jan 2, 2025
...ata-service/src/main/kotlin/com/tencent/bkrepo/common/metadata/dao/blocknode/BlockNodeDao.kt
Outdated
Show resolved
Hide resolved
...biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/controller/SeparateBlockController.kt
Outdated
Show resolved
Hide resolved
...kend/generic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/service/UploadService.kt
Outdated
Show resolved
Hide resolved
...kend/generic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/service/UploadService.kt
Outdated
Show resolved
Hide resolved
...ic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/artifact/GenericLocalRepository.kt
Outdated
Show resolved
Hide resolved
...ic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/artifact/GenericLocalRepository.kt
Outdated
Show resolved
Hide resolved
...ic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/artifact/GenericLocalRepository.kt
Outdated
Show resolved
Hide resolved
...ic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/artifact/GenericLocalRepository.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/com/tencent/bkrepo/common/metadata/service/blocknode/impl/BlockNodeServiceImpl.kt
Show resolved
Hide resolved
...kend/generic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/service/UploadService.kt
Show resolved
Hide resolved
cnlkl
requested changes
Jan 8, 2025
...etadata/metadata-api/src/main/kotlin/com/tencent/bkrepo/common/metadata/constant/Constant.kt
Show resolved
Hide resolved
...main/kotlin/com/tencent/bkrepo/common/artifact/repository/core/AbstractArtifactRepository.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/com/tencent/bkrepo/common/metadata/service/blocknode/impl/BlockNodeServiceImpl.kt
Show resolved
Hide resolved
...kend/generic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/service/UploadService.kt
Outdated
Show resolved
Hide resolved
...end/generic/api-generic/src/main/kotlin/com/tencent/bkrepo/generic/pojo/SeparateBlockInfo.kt
Outdated
Show resolved
Hide resolved
...ic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/artifact/GenericLocalRepository.kt
Outdated
Show resolved
Hide resolved
...ic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/artifact/GenericLocalRepository.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/com/tencent/bkrepo/common/metadata/service/blocknode/impl/BlockNodeServiceImpl.kt
Outdated
Show resolved
Hide resolved
...kend/generic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/service/UploadService.kt
Outdated
Show resolved
Hide resolved
...kend/generic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/service/UploadService.kt
Show resolved
Hide resolved
cnlkl
requested changes
Jan 10, 2025
...ice/src/main/kotlin/com/tencent/bkrepo/common/metadata/service/blocknode/BlockNodeService.kt
Show resolved
Hide resolved
...ce/src/main/kotlin/com/tencent/bkrepo/common/metadata/service/node/impl/NodeDeleteSupport.kt
Show resolved
Hide resolved
...ic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/artifact/GenericLocalRepository.kt
Show resolved
Hide resolved
...ic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/artifact/GenericLocalRepository.kt
Show resolved
Hide resolved
...kend/generic/biz-generic/src/main/kotlin/com/tencent/bkrepo/generic/service/UploadService.kt
Show resolved
Hide resolved
) | ||
|
||
// 获取节点信息并验证节点是否存在 | ||
val node = ArtifactContextHolder.getNodeDetail(artifactInfo) ?: run { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
此处为什么要验证节点是否存在
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
严格意义上来说 因为删除的都是旧node,且有对应旧node的id,所以并发下 并不会删除新建的node,且只有一个线程能够成功走到后续逻辑,因此不需要再次检验node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.