Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 分块上传优化 #2813 #2816

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Conversation

zzdjx
Copy link
Collaborator

@zzdjx zzdjx commented Dec 3, 2024

No description provided.

@zzdjx zzdjx requested review from owenlxu and removed request for cnlkl, felixncheng and yaoxuwan December 3, 2024 08:02
@zzdjx zzdjx added the for test label Dec 19, 2024
felixncheng
felixncheng previously approved these changes Dec 25, 2024
@cnlkl cnlkl self-requested a review January 6, 2025 11:42
)

// 获取节点信息并验证节点是否存在
val node = ArtifactContextHolder.getNodeDetail(artifactInfo) ?: run {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处为什么要验证节点是否存在

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

严格意义上来说 因为删除的都是旧node,且有对应旧node的id,所以并发下 并不会删除新建的node,且只有一个线程能够成功走到后续逻辑,因此不需要再次检验node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants