Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ft bklogin log #309

Merged
merged 6 commits into from
Mar 10, 2022
Merged

Ft bklogin log #309

merged 6 commits into from
Mar 10, 2022

Conversation

wklken
Copy link
Collaborator

@wklken wklken commented Mar 9, 2022 •
edited
Loading

  • 移除oauth2残留依赖/代码/变更及兼容
  • 移除原先登录上的用户管理静态页面及资源
  • 移除admin静态资源
  • 部分重构:
    • 合并使用一个http.py
    • 删除部分无用函数
    • 增加一些debug日志

@wklken wklken requested a review from IMBlues March 9, 2022 09:00
@wklken wklken mentioned this pull request Mar 9, 2022
Closed
IMBlues
IMBlues reviewed Mar 9, 2022
View reviewed changes
Copy link
Contributor

@IMBlues IMBlues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确定这些 select2 前端没有用到么？

@wklken
Copy link
Collaborator Author

wklken commented Mar 10, 2022 

bklogin/templates/account/base.html
23:    <link rel="stylesheet" type="text/css" href="{{STATIC_URL}}assets/select2-3.5.2/select2.css" rel="stylesheet">
114:      <script src="{{STATIC_URL}}assets/select2-3.5.2/select2.js"></script>

唯一引用的页面已经一并删除了

@wklken
Copy link
Collaborator Author

wklken commented Mar 10, 2022

加了一个 commit, 删除bkDialog和layout_header

        deleted:    static/assets/bkDialog-1.0/css/ui-dialog.css
        deleted:    static/assets/bkDialog-1.0/js/dialog.js
        deleted:    static/css/layout_head.css
        deleted:    static/css/layout_head.min.css
        deleted:    static/css_ce/layout_head.css
        deleted:    static/css_ce/layout_head.min.css

@IMBlues IMBlues merged commit bb349af into TencentBlueKing:development Mar 10, 2022
@wklken wklken mentioned this pull request May 7, 2022
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IMBlues IMBlues IMBlues approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wklken @IMBlues