Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve the error message when app_desc.yaml contains invalid modules data(both v2 and v3) #1443

Merged
merged 4 commits into from
Jul 4, 2024
Merged

feat: improve the error message when app_desc.yaml contains invalid modules data(both v2 and v3) #1443

merged 4 commits into from
Jul 4, 2024

Conversation

piglei
Copy link
Collaborator

@piglei piglei commented Jul 2, 2024

  • feat: improve the error message when app_desc.yaml contains invalid modules data(both v2 and v3)
  • improve the test code for v2/v3 handler

@piglei piglei requested review from jamesgetx and narasux July 2, 2024 08:41
@piglei piglei force-pushed the fix-desc-switch branch from 12c78d2 to 40b3b30 Compare July 3, 2024 02:52
@piglei piglei requested a review from narasux July 3, 2024 06:35
@narasux narasux merged commit f71fefd into TencentBlueKing:main Jul 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesgetx jamesgetx jamesgetx left review comments

@narasux narasux narasux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piglei @jamesgetx @narasux