Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add live apy to home #90

Merged
merged 9 commits into from
Aug 23, 2021
Merged

add live apy to home #90

merged 9 commits into from
Aug 23, 2021

Conversation

vmaark
Copy link
Contributor

@vmaark vmaark commented Aug 16, 2021

No description provided.

@vercel
Copy link

vercel bot commented Aug 16, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tenderize/tender-app/3K97PqJLNY2e1Sw25PATF7gRxRxC
✅ Preview: https://tender-app-git-mv-graph-data-apy-tenderize.vercel.app

@vmaark vmaark requested a review from kyriediculous August 17, 2021 12:30
@kyriediculous
Copy link
Member

Looks good at first glance, will do some manual testing on this when the contracts are redeployed

@kyriediculous
Copy link
Member

rebased this on top of master to redeploy the preview with the latest contract addresses

@kyriediculous
Copy link
Member

Looks like I still have to refresh before the rewards show the correct amount.

To reproduce:

Request 100 LPT from faucet
Approve 100 LPT for stake
Deposit 100 LPT
See Stake is 100 LPT ✅
See Rewards is 100 LPT 🔴
Refresh
Rewards is now 0 LPT

@kyriediculous
Copy link
Member

kyriediculous commented Aug 21, 2021 •
edited
Loading

I Believe one potential solution is to refetch the subgraph query until data.tenderizerStake gets updates with the deposit amount and only re-render the component (or at least the specific infocard) when that is the case.

@vmaark
Copy link
Contributor Author

vmaark commented Aug 23, 2021

fixing rewards updating issue in a separate PR

@vmaark vmaark merged commit 5b7b3a1 into master Aug 23, 2021
@kyriediculous kyriediculous deleted the mv/graph-data-apy branch August 25, 2021 11:54
@kyriediculous kyriediculous mentioned this pull request Aug 25, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyriediculous kyriediculous Awaiting requested review from kyriediculous

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmaark @kyriediculous