Moved profiling to the begining of import flow #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shtripat
reviewed
Nov 20, 2018
|
@shirshendu Yes we need a PR there |
Codecov Report
@@ Coverage Diff @@
## master #1064 +/- ##
=========================================
Coverage ? 81.51%
=========================================
Files ? 90
Lines ? 3754
Branches ? 487
=========================================
Hits ? 3060
Misses ? 596
Partials ? 98
Continue to review full report at Codecov.
|
shtripat
reviewed
Dec 3, 2018
tendrl/commons/objects/cluster/atoms/import_cluster/__init__.py
Outdated
Show resolved
Hide resolved
tendrl/commons/objects/cluster/atoms/import_cluster/__init__.py
Outdated
Show resolved
Hide resolved
anmolsachan
force-pushed
the
master
branch
2 times, most recently
from
1db77e5 to
a8a512a
Compare
|
Fix the commit message and pep8 issues. |
anmolsachan
force-pushed
the
master
branch
2 times, most recently
from
41e2c6d to
3d256d9
Compare
|
@anmolsachan Fix the build issues including pep8. Still failing. |
|
@shtripat This PR does not need any change w.r.t pep8. I have verified locally. This can be merged |
|
Need to merge this, otherwise, upstream profile enable won't happen part of import flow. |
tendrl-bug-id: Tendrl/issues/1065 bugzilla: 1655420 Signed-off-by: Anmol Sachan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tendrl-bug-id: /issues/1065
bugzilla: 1655420
Signed-off-by: Anmol Sachan [email protected]