Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter controls don’t seem to match PatternFly Filter control #638

Closed
cloudbehl opened this issue Sep 25, 2017 · 3 comments
Closed

Filter controls don’t seem to match PatternFly Filter control #638

cloudbehl opened this issue Sep 25, 2017 · 3 comments

Comments

@cloudbehl
Copy link
Member

Filter controls don’t seem to match PatternFly Filter control (https://www.patternfly.org/pattern-library/forms-and-controls/filter/#/overview)

@cloudbehl
Copy link
Member Author

cloudbehl commented Sep 26, 2017

A filter is not readily available in a patternfly new build. So we need to update the patternfly packages in order to make the filter work and the UI needs to be tested very well with the new version.

"angular-patternfly": "~4.11.0",
"patternfly": "~3.27.5",

We tried updating the version, few functionalities were hampered eg. bootstrap datepicker(removed in new version). So, it will be good idea to take it in next development cycle. @nthomas-redhat

@a2batic
Copy link
Member

a2batic commented Nov 8, 2017

@cloudbehl @gnehapk, the bug has been fixed with tendrl-ui-1.5.4-20171107T133229.ed61125.noarch.rpm (latest master build). Please verify.

@gnehapk
Copy link
Member

gnehapk commented Dec 1, 2017

Closing this issue, as its been opened for quite long time. Please feel free to reopen if the issue still persists.

@gnehapk gnehapk closed this as completed Dec 1, 2017
a2batic pushed a commit to a2batic/ui that referenced this issue Dec 6, 2017
Bug fix

Bug fix
Tendrl-bug-id: Tendrl#719

Bug fix
Tendrl-bug-id: Tendrl#721

Update tendrl-ui.spec

Update package.json

Update Makefile

Bug fix
Tendrl-bug-id: Tendrl#723

Few fixes

Hide bottom line when no records present

Fixes filter bugs
Bug id: Tendrl#638 Tendrl#726

Replaced alert drawer with notification drawer

Bug fixes and enhancement
Tendrl-bug-id: Tendrl#663 Tendrl#728 Tendrl#733

Bug Fix
Tendrl-bug-id: Tendrl#738

Bug fix
Tendrl-bug-id: Tendrl#728 Tendrl#740

Update tendrl-ui.spec

Update Makefile

Fixed bugs

handled import failed state

Checking deleted flag for volume state

Update tendrl-ui.spec

Update Makefile

Small Bugs fix
Tendrl-bug-id: Tendrl#747 Tendrl#752 Tendrl#753 Tendrl#754 Tendrl#755

Update tendrl-ui.spec

Update Makefile

Browser-sync and editorconfig to ease contributing experience

New cluster-based left-hand-menus

Updated mock json endpoints

Modified browser-sync server to not proxy mock json endpoints

Implemented the context specific navigation

Some code cleanup to pass linting errors

Removed the ambiguity between using angular and the jQuery plugin to manage navigation state

Added tasks back in

Fixed the angular-patternfly version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants