Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task details button is truncated in Chrome, but not Firefox #645

Closed
julienlim opened this issue Sep 28, 2017 · 4 comments
Closed

Task details button is truncated in Chrome, but not Firefox #645

julienlim opened this issue Sep 28, 2017 · 4 comments

Comments

@julienlim
Copy link
Member

julienlim commented Sep 28, 2017

Task details button is truncated in Chrome, but not Firefox

Chrome:
screen shot 2017-09-28 at 2 15 11 pm

Firefox:
screen shot 2017-09-28 at 2 15 27 pm

@gnehapk @Tendrl/tendrl-frontend @nthomas-redhat @Tendrl/tendrl-qe @mcarrano

@mcarrano
Copy link

I have seen a similar effect on the Cluster Detail pages.

screen shot 2017-09-28 at 2 28 06 pm

In general, it's not a great idea to truncate button labels unless absolutely necessary. Seems like there is adequate white space in the list entry to fit the buttons without truncating. It we are going to use a button to display details rather than the hyperlink of the object name, then recommend shortening the label to just "Details." It should be clear to the user that these are details of the object currently in view.

@gnehapk
Copy link
Member

gnehapk commented Sep 29, 2017

@mcarrano @julienlim Button label gets truncated if it doesn't have space enough to fit and the labels are visible on hover. On "100%" zoom, the button labels are visible properly. Attaching screenshot for the same.

screenshot from 2017-09-29 09-12-51

So, when the page is getting zoomed in or out, the labels will adjust accordingly and gets truncated if it doesn't fit and are displayed on hovering.

On task list page, since there are enough space, we will update it.

a2batic added a commit to a2batic/ui that referenced this issue Sep 29, 2017
a2batic added a commit to a2batic/ui that referenced this issue Sep 29, 2017
a2batic added a commit to a2batic/ui that referenced this issue Oct 6, 2017
@a2batic
Copy link
Member

a2batic commented Oct 11, 2017

@julienlim @mcarrano , Fixed with tendrl-ui-1.5.2-20171010T124450.4044474.noarch.rpm. Please verify

@julienlim
Copy link
Member Author

Issue fixed and resolved.

screen shot 2017-10-24 at 2 36 42 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants