-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(): upgrade to material/[email protected] #847
Conversation
…input with position input
Opened PR just as a placeholder.. i only solved the compilation errors, but there are lots of small issues around layouts, chips, etc etc |
…in the paging demo
Is there any eta? 😄 |
…opening sometimes at the beggining possible issue would be angular/components#6743
We are trying to target early next week since we also have some data-table features and virtual scroll |
Chip Events:
|
Loading Style/layout |
@jerryorta-dev i think that already happens https://teradata.github.io/covalent/#/components/loading |
Data Table with components
|
I think the chips was introduced before, but great catch. Pushed a commit to fix it |
Dynamic File Input Element Text overlays default text after selecting a file to upload. |
That seems to me like an |
@jotatoledo we are gonna release after we merge this and after i merge another PR with data table features and virtual scroll implementation (basic) |
The paging module seems to effect the md-select. I see that several things are removed from the TdPagingComponent such as the pageSizes, etc... Since these are no longer used I think the css for this component should be removed as well. |
After switching to nightly build and material.beta.10, cdk.beta.10 "@angular/cdk": "^2.0.0-beta.10",
"@angular/material": "^2.0.0-beta.10",
"@covalent/core": "git+https://github.com/Teradata/covalent-nightly.git", The paginator still works before upgrade but now there is error message
My paging code <td-paging-bar #pagingBar [pageSizes]="[defaultPagesize, 20, 25]" [total]="totalRows" (change)="onPage($event)">
<span td-paging-bar-label hide-xs>Row per page:</span>
{{pagingBar.range}} <span hide-xs>of {{pagingBar.total}}</span>
</td-paging-bar> Remove the |
@tuanngominh if you are using the nightly build, you need to be aware that there might be breaking changes like that one. |
Description
Making covalent support all the breaking changes (and deprecating changes) coming from material following their changelog https://github.com/angular/material2/blob/master/CHANGELOG.md#200-beta10-découpage-panjandrum-2017-08-29
What's included?
Test Steps
yarn install
ng serve
General Tests for Every PR
ng serve --aot
still works.npm run lint
passes.npm test
passes and code coverage is not lower.npm run build
still works.