Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): upgrade to material/[email protected] #847

Merged
merged 22 commits into from
Sep 1, 2017

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Aug 31, 2017

Description

Making covalent support all the breaking changes (and deprecating changes) coming from material following their changelog https://github.com/angular/material2/blob/master/CHANGELOG.md#200-beta10-découpage-panjandrum-2017-08-29

What's included?

  • 68dcd00 fix(layout-docs): workaround for now since MdSidenav has issues when opening -
  • sometimes at the beggining
  • a851506 chore(dynamic-forms): update slider label using new classes
  • afb48b6 chore(dynamic-forms): use flex row to stetch inputs/textareas
  • 83b394b fix(paging): fix padding on md-selects used in td-paging-bar
  • 70583f2 chore(paging): set fixed 30px in input since it has 200px by default in the paging demo
  • df549f9 fix(data-table): fix color of pseudo checkboxes in data-table
  • dce9a03 fix(chips): md-basic-chip behaves diff now so click on chip was not working
  • 893d831 chore(): update platform package.json's with bumps
  • e061084 chore(): bump to [email protected] since its a requirement for angular/material now
  • 67c6de9 chore(): rename md-list-icon and md-list-avatar to mdListIcon and mdListAvatar
  • c4c6e74 chore(): rename md-ripple to mdRipple
  • ce77bfd chore(): rename md-input-container to md-form-field and its classes
  • 5780da4 chore(): rename md-card-avatar to mdCardAvatar
  • e7d57a4 chore(): rename md-tab-label to mdTabLabel
  • 9b96116 chore(): rename md-line with mdLine
  • 3078ece fix(steps): fix demo to start in vertical mode
  • 5ed8a3e feat(): rename mat-sidenav- classes to mat-drawer- and replace align input with position input
  • 1a01edb fix(): fix breaking changes from cdk imports and interface modifications in material
  • 804ba29 chore(): update rollup script with cdk dependencies
  • ba65133 chore(): upgrade to material/[email protected]

Test Steps

  • yarn install
  • ng serve
  • Test everything!

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.

@emoralesb05
Copy link
Contributor Author

Opened PR just as a placeholder.. i only solved the compilation errors, but there are lots of small issues around layouts, chips, etc etc

@jotatoledo
Copy link
Contributor

Is there any eta? 😄

@emoralesb05
Copy link
Contributor Author

We are trying to target early next week since we also have some data-table features and virtual scroll base implementation :P so stay tuned!

@jerryorta-dev
Copy link
Contributor

Chip Events:
http://localhost:4200/#/components/chips

ERROR Error: ExpressionChangedAfterItHasBeenCheckedError

chip-event-error

@jerryorta-dev
Copy link
Contributor

Loading Style/layout
http://localhost:4200/#/components/loading

Input label crashes into tab header underline.
loading-input-label-crash

@kyleledbetter
Copy link
Contributor

@jerryorta-dev
Copy link
Contributor

Data Table with components
http://localhost:4200/#/components/data-table

ExpressionChangedAfterItHasBeenCheckedError: when changing number or rows displayed.

data-table-error

@emoralesb05
Copy link
Contributor Author

I think the chips was introduced before, but great catch. Pushed a commit to fix it

@jerryorta-dev
Copy link
Contributor

jerryorta-dev commented Aug 31, 2017

Dynamic File Input Element
http://localhost:4200/#/components/dynamic-forms

Text overlays default text after selecting a file to upload.
Change events are not detected.

dynamic-file-input

@emoralesb05
Copy link
Contributor Author

emoralesb05 commented Aug 31, 2017

That seems to me like an mdInput issue, so we should probably open an issue to track this. Thanks @jerryorta-dev 😄

@emoralesb05
Copy link
Contributor Author

@jotatoledo we are gonna release after we merge this and after i merge another PR with data table features and virtual scroll implementation (basic)

@emoralesb05 emoralesb05 merged commit d53ef53 into develop Sep 1, 2017
@emoralesb05 emoralesb05 deleted the feature/material-beta.10 branch September 1, 2017 21:16
@akrepon
Copy link

akrepon commented Sep 5, 2017

The paging module seems to effect the md-select. I see that several things are removed from the TdPagingComponent such as the pageSizes, etc... Since these are no longer used I think the css for this component should be removed as well.

@jennmedellin jennmedellin restored the feature/material-beta.10 branch September 5, 2017 22:02
@emoralesb05 emoralesb05 deleted the feature/material-beta.10 branch September 5, 2017 22:15
@tuanngominh
Copy link

tuanngominh commented Sep 6, 2017

After switching to nightly build and material.beta.10, cdk.beta.10

"@angular/cdk": "^2.0.0-beta.10",
"@angular/material": "^2.0.0-beta.10",
"@covalent/core": "git+https://github.com/Teradata/covalent-nightly.git",

The paginator still works before upgrade but now there is error message

Template parse errors:
Can't bind to 'pageSizes' since it isn't a known property of 'td-paging-bar'

My paging code

<td-paging-bar #pagingBar [pageSizes]="[defaultPagesize, 20, 25]" [total]="totalRows" (change)="onPage($event)">
  <span td-paging-bar-label hide-xs>Row per page:</span>
  {{pagingBar.range}} <span hide-xs>of {{pagingBar.total}}</span>
</td-paging-bar>

Remove the [pageSizes]="[defaultPagesize, 20, 25]", then paginator works again.

@emoralesb05
Copy link
Contributor Author

@tuanngominh if you are using the nightly build, you need to be aware that there might be breaking changes like that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants